Skip to content

Fix edit at root picking wrong prim - #360

Open
WolfGangS wants to merge 1 commit into
AlchemyViewer:developfrom
WolfGangS:bugfix/edit-at-root
Open

Fix edit at root picking wrong prim#360
WolfGangS wants to merge 1 commit into
AlchemyViewer:developfrom
WolfGangS:bugfix/edit-at-root

Conversation

@WolfGangS

@WolfGangS WolfGangS commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix edit at root selecting wrong prim

image

@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved pivot-point selection when manipulating a single root object, ensuring transformations use the correct root-object pivot.

Walkthrough

LLManip::getPivotPoint() now retrieves the pivot from the selected object’s first root object when the single-object and root-axis conditions apply.

Changes

Pivot selection

Layer / File(s) Summary
Use the first root object
indra/newview/llmanip.cpp		 LLManip::getPivotPoint() changes pivot lookup from getFirstObject() to getFirstRootObject(true).

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ryemutt

Poem

A rabbit checks the pivot’s place,
And finds the root with careful grace.
The manipulator turns just right,
Guided by the object’s height.
One small change, a steadier view.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the bug fix and includes an image, but it omits the required issue link, checklist, testing details, and additional context. Add the required template sections, link a relevant issue, describe the reproduction and fix, and document testing and checklist status.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the bug fix for incorrect prim selection during edit-at-root operations.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c/cpp viewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@WolfGangS